Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-30537] Update Opensearch dependency to version 2.3 #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FLINK-30537] Update Opensearch dependency to version 2.3 #4

wants to merge 1 commit into from

Conversation

amirhalatzi
Copy link

Hi!

During a project we're working on we decided to use Flink over Opensearch 2.3, which seems to have a breaking change of removing the type property from responses.

This PR updates the dependency and the relevant tests.

I'd be happy to do any necessary changes to make sure this release is differentiated from the one meant for Opensearch 1.3.

Thanks!

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2022

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@amirhalatzi amirhalatzi changed the title Update Opensearch dependency to version 2.3 [FLINK-30537] Update Opensearch dependency to version 2.3 Jan 2, 2023
@reta
Copy link
Member

reta commented Jan 3, 2023

@amirhalatzi the OpenSearch 2.x has JDK-11 baseline (the connector works with 2.x as well). Please correct me if I am wrong, Apache Flink still supports JDK 8 (although it is deprecated).

@amirhalatzi
Copy link
Author

@reta you're right. Java 8 is still supported. As for the current connector working with 2.x - you can see in the PR that the API has changed.
Any ideas on how to support both versions without upgrading to Java 11?

@reta
Copy link
Member

reta commented Jan 4, 2023 •
edited
Loading

@reta you're right. Java 8 is still supported. As for the current connector working with 2.x - you can see in the PR that the API has changed. Any ideas on how to support both versions without upgrading to Java 11?

@amirhalatzi this is only test code which uses type, sadly the Bulk API in 1.x requires it (at least for responses), it might be possible to rewrite this test case as integration (in this case the responses don't need to be mocked). The connector's code itself does not use any deprecated APIs though.

@reta reta mentioned this pull request Feb 20, 2023
Closed
5 tasks
@kurnoolsaketh kurnoolsaketh mentioned this pull request Aug 31, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=Connectors/Opensearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amirhalatzi @reta